Merge pull request #696 from DadUndead/master

fix(controls): Set ARIA orientation in VgVolume, Set play/pause button ARIA label depends on current state.
videogular · Apr 1, 2018 · b4447bf · b4447bf
2 parents 0416174 + 5343bca
commit b4447bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/controls/vg-play-pause/vg-play-pause.ts b/src/controls/vg-play-pause/vg-play-pause.ts
@@ -12,7 +12,7 @@ import { Subscription } from 'rxjs/Subscription';
              [class.vg-icon-play_arrow]="getState() === 'paused' || getState() === 'ended'"
              tabindex="0"
              role="button"
-             aria-label="play pause button"
+             [attr.aria-label]="getState() === 'paused'?'play':'pause'"
              [attr.aria-valuetext]="ariaValue">
         </div>`,
     styles: [ `

diff --git a/src/controls/vg-volume/vg-volume.ts b/src/controls/vg-volume/vg-volume.ts
@@ -19,6 +19,7 @@ import { Subscription } from 'rxjs/Subscription';
             [attr.aria-valuenow]="ariaValue"
             aria-valuemin="0"
             aria-valuemax="100"
+            aria-orientation="horizontal"
             [attr.aria-valuetext]="ariaValue + '%'"
             (click)="onClick($event)"
             (mousedown)="onMouseDown($event)">