Option.MAP_VALUES_AS_ADDITIONAL_PROPERTIES

[electrosaur]

I'm not able to get this working. I'm just getting, for example,
mapOfData -> "{"$ref":"#/$defs/java.util.Map(java.lang.String,com.guidewire.integrationgateway.rest.model.CustomData)"}"
with no additionalProperties. My config is:

        JacksonModule module = new JacksonModule(FLATTENED_ENUMS_FROM_JSONPROPERTY, RESPECT_JSONPROPERTY_REQUIRED);
        SchemaGeneratorConfigBuilder configBuilder = new SchemaGeneratorConfigBuilder(SchemaVersion.DRAFT_2019_09, OptionPreset.PLAIN_JSON)
            .with(module)
            .with(EXTRA_OPEN_API_FORMAT_VALUES)
            .with(MAP_VALUES_AS_ADDITIONAL_PROPERTIES)
            .with(FLATTENED_ENUMS)
            .with(DEFINITIONS_FOR_ALL_OBJECTS);
        configBuilder.forTypesInGeneral()
            .withIdResolver(scope -> scope.getType().getTypeName());
        configBuilder.forTypesInGeneral()
            .withDefinitionNamingStrategy(new DefaultSchemaDefinitionNamingStrategy() {
                @Override
                public String getDefinitionNameForKey(DefinitionKey key, SchemaGenerationContext generationContext) {
                    String superDefinition = super.getDefinitionNameForKey(key, generationContext);
                    return key.getType().getTypeName();
                }
            });
        configBuilder.forTypesInGeneral().withCustomDefinitionProvider(new CustomDefinitionProviderV2() {
            @Override
            public CustomDefinition provideCustomSchemaDefinition(ResolvedType javaType, SchemaGenerationContext context) {
                if (javaType.isInstanceOf(Enum.class)) {
                    ObjectNode standardDefinition = context.createStandardDefinition(javaType, this);
                    return new CustomDefinition(standardDefinition, true);
                }
                return null;
            }
        });

Caused by DEFINITIONS_FOR_ALL_OBJECTS as well? I tried adding to CustomDefinitionProvideV2 for javaType.isInstanceOf(Map.class) but the standard definition too doesn't create the additionalProperties as desired.

Any solution or suggestions?
Thanks.

[CarstenWickner]

Hi Shankar,

The given entry is just the reference to a sub-schema under the $defs node.

{
  "$ref":"#/$defs/java.util.Map(java.lang.String,com.guidewire.integrationgateway.rest.model.CustomData)"
}

What does that sub-schema look like under that path in the overall output? That's where you'd find the "additionalProperties".
I suspect you're just looking in the wrong place for it. 😉

{
  "$defs": {
    "java.util.Map(java.lang.String,com.guidewire.integrationgateway.rest.model.CustomData)": {
      "additionalProperties": {
        "type": "object",
         ...?
      }
    }
  }
}

[electrosaur]

Carsten:
You are so correct! Kicking myself! Cannot now fathom why I was expecting it to get inlined. I was just looking at the properties node. Thanks and appreciate your patience.