Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __eq__ so classes can be compared for equality #4

Closed
vickumar1981 opened this issue Apr 2, 2020 · 5 comments
Closed

Add __eq__ so classes can be compared for equality #4

vickumar1981 opened this issue Apr 2, 2020 · 5 comments
Assignees
@BattiniSandeep
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@vickumar1981
Copy link
Owner

All implemented classes need to have a dunder __eq__ method so that they can be compared for equality.
@vickumar1981 vickumar1981 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 2, 2020
@BattiniSandeep
Copy link
Contributor

Would like to work on this. Can you please assign this to me. Thanks

@BattiniSandeep
Copy link
Contributor

@vickumar1981 I think below are the classes which need eq.

  • Left
  • Right
  • Future
  • Some
  • Empty
  • Failure
  • Success

Let me know if I miss anything.

@vickumar1981
Copy link
Owner Author

@BattiniSandeep looks about right. thanks again!!

@BattiniSandeep
Copy link
Contributor

Hii @vickumar1981 I have raised a pr, It addresses all the classes except Future. Please have look at it. Thanks

@vickumar1981
Copy link
Owner Author

Resolved by: #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BattiniSandeep BattiniSandeep

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vickumar1981 @BattiniSandeep