Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 0.9.0 not being latest anymore, version dropdown name updating #101

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

Grifs
Copy link
Contributor

@Grifs Grifs commented Dec 19, 2024

fix 0.9.0 not being latest anymore
after page update, check what version we're displaying, match it with the versions.json and display the name as the version dropdown

after page update, check what version we're displaying, match it with the versions.json and display the name as the version dropdown
@Grifs Grifs assigned rcannood and unassigned rcannood Dec 19, 2024
@Grifs Grifs requested a review from rcannood December 19, 2024 09:35
Copy link

github-actions bot commented Dec 19, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-19 19:22 UTC

…reduces the risk of adding files & folder that should not be versioned
@Grifs
Copy link
Contributor Author

Grifs commented Dec 19, 2024

image
image

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Grifs Grifs merged commit d966025 into main Dec 19, 2024
1 check passed
@Grifs Grifs deleted the update_version_dropdown branch December 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants