Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-7509: update common ESLint configs to v9 #54

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

APP-7509: update common ESLint configs to v9 #54

wants to merge 6 commits into from

Conversation

mcous
Copy link
Member

@mcous mcous commented Feb 7, 2025 •
edited
Loading

Overview

This PR updates our common ESLint configs for ESLint v9 and flat configs

Review requests

Scan code for changes. See companion PR in app for runtime testing

@mcous mcous mentioned this pull request Feb 7, 2025
Closed
@mcous mcous force-pushed the APP-7509/mcous/eslint-9 branch from 98a7a83 to 4658154 Compare February 7, 2025 16:52
@mcous mcous force-pushed the APP-7509/mcous/eslint-9 branch from 4658154 to b430350 Compare February 7, 2025 16:56
DTCurrie
DTCurrie approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@DTCurrie DTCurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@mcous mcous marked this pull request as ready for review February 7, 2025 19:12
@mcous mcous requested review from ehhong and Abalaxy February 7, 2025 19:26
Abalaxy
Abalaxy approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@Abalaxy Abalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out to me, looks good!

@mcous mcous requested a review from katiepeters February 10, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiepeters katiepeters katiepeters approved these changes

@DTCurrie DTCurrie DTCurrie approved these changes

@Abalaxy Abalaxy Abalaxy approved these changes

@micheal-parks micheal-parks micheal-parks approved these changes

@ehhong ehhong Awaiting requested review from ehhong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcous @katiepeters @DTCurrie @Abalaxy @micheal-parks