-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-config)!: split config packages #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
608f058
to
bb3b9c0
Compare
This was referenced Nov 27, 2024
bb3b9c0
to
92341b4
Compare
8208c54
to
78d51c3
Compare
31406f2
to
876bc2b
Compare
7d72ede
to
db3dcee
Compare
2844936
to
fbb4429
Compare
03da2c3
to
190557c
Compare
fbb4429
to
c8cba6a
Compare
190557c
to
d16e201
Compare
d938f33
to
a35071b
Compare
ab265b8
to
ee49725
Compare
ethanlookpotts
approved these changes
Dec 3, 2024
katiepeters
reviewed
Dec 3, 2024
ee49725
to
abaf2c5
Compare
katiepeters
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This stack of PRs updates our common JS configs over to their
1.0.0
versions. The main difference between the versions so far andv1
is that (thanks to the ESLint v9 update) the various plugins and configs that we stitch together will be pulled in automatically asdependencies
- simplifying setup by removing most required peer dependencies.pnpm publish
instead of action #48Change log
This PR splits the ESLint config into two separate packages, both of which will be able to contain their relevant dependencies in the next PR
@viamrobotics/eslint-config
@viamrobotics/eslint-config-svelte
Review requests
I've smoke tested these changes with all the projects in
app
and it has all behaved as expected