Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "check if timeout actually happens before giving it as a reason" #33383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "check if timeout actually happens before giving it as a reason" #33383

wants to merge 1 commit into from
+11 −30

Conversation

aressem
Copy link
Member

@aressem aressem commented Feb 21, 2025

Reverts #33374

@aressem
Copy link
Member Author

aressem commented Feb 21, 2025

Suspecting that this one broke : https://factory.vespa.ai/testrun/106551701/test/ReportCoverage::test_reportcoverage__INDEXED

@hmusum
Copy link
Member

hmusum commented Feb 21, 2025

Yes, could be that test needs an update, reporting timeout true when this was not the real reason was one thing that was fixed in Arne's changes, to suggest to hold this a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorncs bjorncs bjorncs approved these changes

@arnej27959 arnej27959 Awaiting requested review from arnej27959

@hmusum hmusum Awaiting requested review from hmusum

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aressem @hmusum @bjorncs