Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct argument order in tensor type assignableTo #33364

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Correct argument order in tensor type assignableTo #33364

merged 2 commits into from
Feb 19, 2025
+35 −24

Conversation

bratseth
Copy link
Member

No description provided.

@bratseth bratseth requested a review from arnej27959 February 19, 2025 16:46
arnej27959
arnej27959 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@arnej27959 arnej27959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bratseth bratseth merged commit bbb8e1c into master Feb 19, 2025
3 checks passed
@bratseth bratseth deleted the bratseth/tensor-type-generalize branch February 19, 2025 17:23
@kkraune
Copy link
Member

kkraune commented Feb 22, 2025

looks like we have a sample app that needs fixing after this: https://github.com/vespa-engine/sample-apps/actions/runs/13437823048/job/37544354655

[ERROR] DocumentReductionDocProcTest.test_happy_path:48 » IllegalArgument Incompatible data types. Got datatype tensor<float>(x[768]) (code: 21), expected datatype tensor<bfloat16>(x[768]) (code: 21)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnej27959 arnej27959 arnej27959 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bratseth @kkraune @arnej27959