Support other finish reasons for OpenAiClient (deepseek) #33327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
When hitting OpenAI-compatible endpoints, such as https://docs.together.ai/docs/openai-api-compatibility, other models may often have other finish_reasons than OpenAI's models, based on their
stop
-tokens.Examples:
meta-llama/Llama-3.3-70B-Instruct-Turbo
:deepseek-ai/DeepSeek-R1
:Before this PR, a request to this endpoint would result in:
This PR changes the default behavior to only throw exception on
finish_reason=error
, and let through other ones, making ourOpenAiClient
more generic.