Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add quoting when sorting on "[rank]" or "[relevance]" #33217

Merged
merged 1 commit into from
Jan 31, 2025
Merged

add quoting when sorting on "[rank]" or "[relevance]" #33217

merged 1 commit into from
Jan 31, 2025

Conversation

arnej27959
Copy link
Member

@geirst please review

geirst
geirst approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@geirst geirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test as well.

@arnej27959 arnej27959 merged commit d888663 into master Jan 31, 2025
3 checks passed
@arnej27959 arnej27959 deleted the arnej/quote-rank-sorting branch January 31, 2025 14:40
@arnej27959 arnej27959 mentioned this pull request Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratseth bratseth bratseth approved these changes

@geirst geirst geirst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnej27959 @bratseth @geirst