Skip to content

Commit

Permalink
Merge pull request #27 from verypossible/1.35.1
Browse files Browse the repository at this point in the history
Bump Serverless to 1.35.1
  • Loading branch information
brianz authored Dec 19, 2018
2 parents 186f21b + d435ecb commit 01baece
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 56 deletions.
35 changes: 0 additions & 35 deletions Dockerfile-python2

This file was deleted.

19 changes: 4 additions & 15 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
NAME = verypossible/serverless
SERVERLESS_VERSION = 1.29.0
YARN_VERSION = 1.6.0
SERVERLESS_VERSION = 1.35.1
YARN_VERSION = 1.12.3

.PHONY: all py2 py3 shell
.PHONY: all py3 shell


all : py2 py3

py2 :
docker build \
-t $(NAME):$(SERVERLESS_VERSION)-python2 \
-f Dockerfile-python2 \
--build-arg SERVERLESS_VERSION=$(SERVERLESS_VERSION) \
--build-arg YARN_VERSION=$(YARN_VERSION) \
.
all : py3

py3 :
docker build \
Expand All @@ -23,8 +15,5 @@ py3 :
--build-arg YARN_VERSION=$(YARN_VERSION) \
.

py2-shell :
docker run --rm -it $(NAME):$(SERVERLESS_VERSION)-python2 bash

py3-shell :
docker run --rm -it $(NAME):$(SERVERLESS_VERSION) bash
8 changes: 2 additions & 6 deletions hooks/build
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,10 @@ DOCKERFILE=Dockerfile

echo "Building $CACHE_TAG using build hook!"

if [[ $CACHE_TAG == *"python2"* ]]; then
DOCKERFILE=Dockerfile-python2
fi

echo "Using $DOCKERFILE for build"

docker build \
--build-arg SERVERLESS_VERSION=1.29.0 \
--build-arg YARN_VERSION=1.6.0 \
--build-arg SERVERLESS_VERSION=1.35.1 \
--build-arg YARN_VERSION=1.12.3 \
-f $DOCKERFILE \
-t $IMAGE_NAME .

0 comments on commit 01baece

Please sign in to comment.