Add real HTTP authentication backend #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HTTP authentication library for ratsd. It currently support 3 modes, `passthrough`, `none` and `basic`. `passthrough` backend does not perform any authentication, allowing all requests. `none` is an alias for `passthrough`, and `basic` implements the Basic HTTP authentication scheme defined in RFC7617. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Replace bogus HTTP header check with the real HTTP auth middleware, add the option to support various auth backend type, and remove unnecessary unit test for missing authorization header. Add `auth` as the option to config.yaml for API authentication and authorization mechanism configuration. If this is not specified, the `passthrough` backend will be used (i.e. no authentication will be performed). See auth config from [readme](https://github.com/veraison/services/blob/main/auth/README.md). Note `role` is not used in ratsd, and thus can be removed from config.yaml Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
cowbon
requested review from
thomas-fossati,
deeglaze,
iolivergithub and
jraman567
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add real HTTP authentication backend based on services/auth, and relocate the Authentication check to a middleware. This allows users to pick the authentication scheme (
noneorbasic, as defined in RFC7617) for ratsd.