Fix(core): Allow non-public customOrderLineFields in admin api #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
michaelbromley
merged commit becfe9d
into
vendure-ecommerce:master
30 of 31 checks passed
|
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, adjustDraftOrderLine and other admin mutation on order lines did not include non-public custom OrderLine fields. This fixes that. I think my issue is the same as issue #3342 and this should fix #3342.
I also filtered out internal fields, as custom fields simply marked internal were showing in the order line input for both admin and shop api.
Breaking changes
No known breaking changes
Screenshots
Checklist
📌 Always:
👍 Most of the time: