Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add external owned/minted/byId functions #46

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

ethzoomer
Copy link
Contributor

No description provided.

@ethzoomer ethzoomer requested a review from stas February 13, 2024 14:24
readme.md Outdated
@@ -243,6 +243,9 @@ The returned data/struct of type `GovNft` values represent:
The available methods are:

* `all(_account: address) -> GovNft[]` - returns a list of all `GovNft` structs owned or minted by the given account.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove all ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Removed

@ethzoomer ethzoomer requested a review from stas February 13, 2024 15:42
Copy link
Collaborator

@stas stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ethzoomer ethzoomer merged commit 0d3f069 into govnft Feb 13, 2024
0 of 2 checks passed
@stas stas deleted the minted-owned-byid branch February 27, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants