Removed voting for same pool and 0 voting

Signed-off-by: Andre Cronje <andre.cronje@yearn.finance>
velodrome-finance · Feb 10, 2022 · ad0dadd · ad0dadd
1 parent 09cca22
commit ad0dadd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/contracts/BaseV1-voter.sol b/contracts/BaseV1-voter.sol
@@ -188,6 +188,8 @@ contract BaseV1Voter {
 
             if (isGauge[_gauge]) {
                 int256 _poolWeight = _weights[i] * _weight / _totalVoteWeight;
+                require(votes[_tokenId][_pool] == 0);
+                require(_poolWeight != 0);
                 _updateFor(_gauge);
 
                 poolVote[_tokenId].push(_pool);

diff --git a/test/base.js b/test/base.js
@@ -497,7 +497,7 @@ describe("core", function () {
   });
 
   it("vote hacking", async function () {
-    await gauge_factory.vote(1, [pair.address, pair.address, pair.address, pair.address], [5000,5000,5000,5000]);
+    await gauge_factory.vote(1, [pair.address], [5000]);
     expect(await gauge_factory.usedWeights(1)).to.closeTo((await ve.balanceOfNFT(1)), 1000);
     expect(await bribe.balanceOf(1)).to.equal(await gauge_factory.votes(1, pair.address));
     await gauge_factory.reset(1);
@@ -533,7 +533,7 @@ describe("core", function () {
   });
 
   it("vote hacking break mint", async function () {
-    await gauge_factory.vote(1, [pair.address, pair.address, pair.address, pair.address], [5000,5000,5000,5000]);
+    await gauge_factory.vote(1, [pair.address], [5000]);
 
     expect(await gauge_factory.usedWeights(1)).to.closeTo((await ve.balanceOfNFT(1)), 1000);
     expect(await bribe.balanceOf(1)).to.equal(await gauge_factory.votes(1, pair.address));