VELO pricing bot #2
Conversation
OPS-182 Discord Price Bot
This one mainly needs to fetch the price for the VELO/AERO token from the oracle. There will be an environment variable, say We need to
|
|
@stas this is ready for review |
.env.example
Outdated
| @@ -0,0 +1,16 @@ | |||
| DISCORD_TOKEN_VELO_PRICING= | |||
| WEB3_PROVIDER_URI=https://opt-mainnet.g.alchemy.com/v2/TYO_nS5GvA15ccCxYMEzTkAxQHrqk801 | |||
There was a problem hiding this comment.
We might need to use the public RPC here since we'll be open sourcing this, consider changing it to https://mainnet.optimism.io or any other public RPC
There was a problem hiding this comment.
got specific value i can use?
There was a problem hiding this comment.
https://mainnet.optimism.io should be ok
.github/workflows/tests.yml
Outdated
| name: Python ${{ matrix.python-version }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v4 |
There was a problem hiding this comment.
Ideally this would build the docker image and run the tests in it. Eg
https://github.com/velodrome-finance/api/blob/main/.github/workflows/ci.yml#L16
There was a problem hiding this comment.
moved testing to a separate stage inside Dockerfile
| @@ -0,0 +1,38 @@ | |||
| FROM python:3.10-slim as python-base | |||
There was a problem hiding this comment.
Would suggest using alpine image and packages instead of doing our custom image pre-builds, also no need for virtualenvs since it's all a container... Consider
FROM python:3.10-alpine
RUN apk add --no-cache poetry
RUN poetry install --only main
...
This should cleanup a lot the dockerfile.
There was a problem hiding this comment.
staying with python:3.10-slim for now
| ): | ||
| print("calling pricer") | ||
| price_oracle = w3.eth.contract( | ||
| address=PRICE_ORACLE_ADDRESS, abi=PRICE_ORACLE_ABI |
There was a problem hiding this comment.
nit: i wonder if we can provide the ABI inline to not carry over the whole file for one simple function call.
In ethers we could inline pass the
abi = [
"function getManyRatesWithConnectors(uint8, address[]) external view returns (uint256[])",
]
tests/test_common_sense.py
Outdated
|
|
||
|
|
||
| def test_common_sense(): | ||
| assert 2 == 2 |
There was a problem hiding this comment.
Would suggest to have at least a smoke test related to the bots.data module, this way we know the data layer works fine. I don't think it's worth us testing the discord stuff as the calls will be mainly related to their API which should be tested enough. Thoughts?
There was a problem hiding this comment.
added tests for the data layer
No description provided.