Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile): Check if groupBy check can be generalized to non-polar coordinates #9557

Draft
wants to merge 5 commits into
base: cameron.yick/fix-compile-pie-stack
Choose a base branch
from
Draft

fix(compile): Check if groupBy check can be generalized to non-polar coordinates #9557

wants to merge 5 commits into from
+82 −272

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Mar 8, 2025 •
edited
Loading

Motivation

Changes

Testing

npx vitest run test/stack.test.ts

Checklist
  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@hydrosquall hydrosquall changed the base branch from main to cameron.yick/fix-compile-pie-stack March 8, 2025 14:14
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from 39fdb52 to 92058b5 Compare March 8, 2025 14:23
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 8, 2025 •
edited
Loading

Deploying vega-lite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2845bb0
Status: ✅  Deploy successful!
Preview URL: https://2a131a05.vega-lite.pages.dev
Branch Preview URL: https://cameron-yick-test-remove-pol.vega-lite.pages.dev

View logs

@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from e883ba0 to 8b1c3d4 Compare March 8, 2025 14:41
@hydrosquall hydrosquall changed the title Cameron.yick/test remove polar condition fix(compile): Check if stacking condition solution can be generalized to non-polar coordinate systems Mar 8, 2025
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch 2 times, most recently from a1f716b to ff5fc0c Compare March 8, 2025 15:04
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from ff5fc0c to 1819008 Compare March 8, 2025 15:07
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch 6 times, most recently from a69f1f3 to 09d9cbe Compare March 8, 2025 15:41
@hydrosquall hydrosquall force-pushed the cameron.yick/test-remove-polar-condition branch from c8324cd to 2845bb0 Compare March 8, 2025 15:57
@hydrosquall hydrosquall changed the title fix(compile): Check if stacking condition solution can be generalized to non-polar coordinate systems fix(compile): Check if groupBy check can be generalized to non-polar coordinates Mar 8, 2025
@hydrosquall hydrosquall mentioned this pull request Mar 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hydrosquall