-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Region Selections Vega-Lite #9536
Draft
hydrosquall
wants to merge
27
commits into
main
Choose a base branch
from
cameron.yick/as/regionSelections-redux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd8d1cf
to
8d879ee
Compare
Deploying vega-lite with
|
Latest commit: |
428336c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d8e27187.vega-lite.pages.dev |
Branch Preview URL: | https://cameron-yick-as-regionselect.vega-lite.pages.dev |
bbc02db
to
39e7050
Compare
29222ba
to
3083392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
main
as base branch instead ofnext
Testing
Compare with behavior on live editor (works with plain Vega, no VL involved )
https://vega.github.io/editor/#/gist/ea53c90aa6ea61ce9b545b082ce85fec/spec.json