Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get parse errors and warnings directly from the Monaco editor. #1151

Open
joshpoll opened this issue Feb 19, 2022 · 1 comment
Open

Get parse errors and warnings directly from the Monaco editor. #1151

joshpoll opened this issue Feb 19, 2022 · 1 comment

Comments

@joshpoll
Copy link
Contributor

Parse errors currently come from the jsonc parser, and we don't have access to parse warnings for trailing commas or comments so they don't show up in the log.

This requires us to first implement react-monaco-editor/react-monaco-editor#501, which will give us access to error and warning information from the Monaco editor.

@domoritz
Copy link
Member

Similarly, the schema validation could come from the editor instead of ajv (whose error messages are hard to read).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants