Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Add query observability feature to docs #362

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

pwoznic
Copy link
Contributor

@pwoznic pwoznic commented Dec 2, 2024

Added documentation for the new query observability feature. This contains the long-form updates and the API reference updates will be next.

Several updates for this new feature including capabilities, console UI, release notes, and other misc updates.
Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for luxury-shortbread-acee05 ready!

Name Link
🔨 Latest commit 3b6437c
🔍 Latest deploy log https://app.netlify.com/sites/luxury-shortbread-acee05/deploys/674f87a4e3da8e000810cd8b
😎 Deploy Preview https://deploy-preview-362--luxury-shortbread-acee05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pwoznic pwoznic marked this pull request as ready for review December 2, 2024 20:40
Signed-off-by: Paul Wozniczka <25128922+pwoznic@users.noreply.github.com>
Copy link
Contributor

@omnomagonz omnomagonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwoznic some non-blocking suggestions. Overall the docs look great and most (all?) of my comments are very subjective 😄

import {vars} from '@site/static/variables.json';
import {Config} from '@site/docs/definitions.md';

The List Query Histories API allows you to retrieve, update, and manage query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The List Query Histories API allows you to retrieve, update, and manage query
The List Query Histories API allows you to retrieve, update, and manage query

Are we firm on this name? It sounds a bit odd to me. Could we consider: Query history API or Query history list API?

Non-blocking suggestion 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if firm (we can run by team for sure), but FWIW I'm going by the yaml descriptions where one is for a specific query and the other is to list a group of multiple queries.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW CJ updated the console copy to say “query histories”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that naming convention makes sense with a UI where there's more (visual) context, so this may be a non-issue if our users are familiar with the console/broader context of this.

I think if there's a standalone experience where a user comes across this API it may have some additional cognitive load to understand what exactly it means or does 🙂

query performance, debugging individual queries, and retrieving detailed
information such as the call stack of a query execution.

## List Query Histories Request and Response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may just be a me thing today, but my brain doesn't grok this naming well.

To me even changing it to "List Query History" might resonate more than the plural "Histories". It's a nit, so I'm not firm here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here: if consistency with the UI makes any difference, “Query Histories” is what we use in console.

what you said makes a lot of sense though, @omnomagonz

To get a history of a specific query, send a GET request to
`/v2/queries`. You can specify the `corpus_key`, `chat_id`, and the
`limit` which is the maximum number of historical queries to list. The
response includes an array of query histories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
response includes an array of query histories.
response includes an array of previous queries.

Non-blocking

Comment on lines +13 to +14
The Get Query History API allows you to retrieve detailed history about a
specific query that was made against a corpus. The response includes detailed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Get Query History API allows you to retrieve detailed history about a
specific query that was made against a corpus. The response includes detailed
The Get Query History API allows you to retrieve detailed history about a
specific query that was made against a corpus. The response includes detailed

This may be naming convention, so this is another non-blocking suggestion: could we consider changing this to be (imo) more distinct vs the other List Query Histories API? An alternative here could be: Query Analysis API or Single Query History API.

I think something that can help further differentiate between this single query history object and the other list of multiple queries object could be helpful

Comment on lines 52 to 53
generative response times, users can better understand how our system performs
relative to their business goals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
generative response times, users can better understand how our system performs
relative to their business goals.
generative response times, users can better understand how to fine-tune Vectara to meet their business goals.

non-blocking

Comment on lines 57 to 58
1. Experiment with different query configurations by asking questions of
your data with **Send query**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Experiment with different query configurations by asking questions of
your data with **Send query**.
1. Ask questions of your data with **Send query**.

Non-blocking.

This reads a bit odd to me. I think the intent here is to say: "First, submit a query", but it sort of jumps ahead with "experiment with different queries".

My mind is interpreting this as out of order. I think if we lead with "first, submit a query" and then maybe add a separate step of "use this information to optimize your configuration and submit a new query" this could help

Click **Expand all** to reveal detailed information for each execution stage,
including specific parameters.

Select **Load into Query tab** to go back to query configuration so that you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little unclear to me. How about something like “…to load this configuration into your query tab”?

It just reiterates the button text, but I think it may be clearer than saying “go back to query configuration”.

@pwoznic pwoznic merged commit 34c8604 into vectara:main Dec 3, 2024
6 of 7 checks passed
@pwoznic pwoznic deleted the query-eval branch December 3, 2024 23:12
@pwoznic pwoznic changed the title feat(new) Add query observability feature to docs feat(new): Add query observability feature to docs Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants