fix(bug): Update how metadata structuring is handled in API v2 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Reading Metadata and the v1 to v2 migration guide
✅ Deploy Preview for luxury-shortbread-acee05 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abhishekpradhan
requested changes
Nov 22, 2024
There was a problem hiding this comment.
I think it's a good idea to add additional information, otherwise it's still confusing. Documenting the regex and examples will allow users of this to easily account for this.
I had a follow up questions asking what exactly it converted.
Also might be good to clarify that this only applies to part_metadata and document_metadata
www/docs/api-reference/search-apis/interpreting-responses/metadata.md
Outdated
Show resolved
Hide resolved
Added regex patterns and other misc updates to improve usability
abhishekpradhan
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
Updated Reading Metadata and the v1 to v2 migration guide