added reranker id in the config of chat bot #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeelehsan
changed the title
|
mrderyk
reviewed
Jul 12, 2024
src/components/ChatView.tsx
Outdated
| @@ -56,6 +56,11 @@ export interface Props { | |||
|
|
|||
| // Defines the name of the summary prompt. Defaults to "vectara-summary-ext-v1.2.0". | |||
| summaryPromptName?: string; | |||
|
|
|||
| //Define the reranker Id to be used , Defaults to "272725718" | |||
There was a problem hiding this comment.
nit: Can we add a space after the "//" please?
cjcenizal
reviewed
Jul 12, 2024
src/types.ts
Outdated
| @@ -95,3 +95,5 @@ export type ChatTurn = { | |||
| results: DeserializedSearchResult[]; | |||
| factualConsistencyScore?: number; | |||
| }; | |||
|
|
|||
| export type RerankerIds = 272725717 | 272725719 | 272725718 | |||
There was a problem hiding this comment.
This should be singular: RerankerId
src/useChat.ts
Outdated
| @@ -68,7 +75,7 @@ export const useChat = ({ | |||
| queryValue: query, | |||
| rerank: true, | |||
| rerankNumResults: 7, | |||
| rerankerId: 272725718, | |||
| rerankerId: rerankerId, | |||
There was a problem hiding this comment.
Nit, this can be simply rerankerId. JS will infer that we're assigning a variable of this name to a field of the same name. This comment applies in a few other places.
adeelehsan
changed the title
mrderyk
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.