diff --git a/src/prep.py b/src/prep.py index 8b99a44..28909cf 100644 --- a/src/prep.py +++ b/src/prep.py @@ -55,7 +55,29 @@ def prep_data(dataset_path, input_length, output_length): def untar(tar_path): with tarfile.open(tar_path) as tf: - tf.extractall(path='./', members=None) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path="./", members="None") def file_paths(data_path): return [join(data_path, name) for name in listdir(data_path)]