Add VSCode tasks for building nativeaudio #168
Conversation
WalkthroughThe pull request modifies the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant TaskRunner as VSCode Task Runner
participant Gen as CMake Generate Task
participant BuildDebug as CMake Build (Debug)
participant BuildRelease as CMake Build (Release)
Dev->>TaskRunner: Initiate NativeAudio build
TaskRunner->>Gen: Execute "CMake - Generate build files"
Gen-->>TaskRunner: Build files generated
TaskRunner->>BuildDebug: Run "CMake - Build NativeAudio (Debug)"
BuildDebug-->>TaskRunner: Debug build complete
TaskRunner->>BuildRelease: Run "CMake - Build NativeAudio (Release)"
BuildRelease-->>TaskRunner: Release build complete
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.vscode/tasks.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build (macos-latest)
- GitHub Check: build (windows-latest)
- GitHub Check: Analyze (cpp)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Analyze (csharp)
🔇 Additional comments (1)
.vscode/tasks.json (1)
24-36: Approved addition of the "CMake - Generate build files" task.
This new task is correctly configured to generate build files using CMake with clear arguments and appropriate problem matchers.
| { | ||
| "type": "shell", | ||
| "label": "CMake - Build NativeAudio (Release)", | ||
| "command": "cmake", | ||
| "args": ["--build", "./NativeAudio/out", "--config", "Release"], | ||
| "group": "build", | ||
| "problemMatcher": ["$gcc", "$msCompile"], | ||
| "dependsOn": ["CMake - generate build files"] | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix dependency label casing for the Release build task.
Similar to the Debug build task, the "dependsOn" field here references "CMake - generate build files" with incorrect casing. Update it to the correct label "CMake - Generate build files".
- "dependsOn": ["CMake - generate build files"]
+ "dependsOn": ["CMake - Generate build files"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "type": "shell", | |
| "label": "CMake - Build NativeAudio (Release)", | |
| "command": "cmake", | |
| "args": ["--build", "./NativeAudio/out", "--config", "Release"], | |
| "group": "build", | |
| "problemMatcher": ["$gcc", "$msCompile"], | |
| "dependsOn": ["CMake - generate build files"] | |
| } | |
| { | |
| "type": "shell", | |
| "label": "CMake - Build NativeAudio (Release)", | |
| "command": "cmake", | |
| "args": ["--build", "./NativeAudio/out", "--config", "Release"], | |
| "group": "build", | |
| "problemMatcher": ["$gcc", "$msCompile"], | |
| "dependsOn": ["CMake - Generate build files"] | |
| } |
| { | ||
| "type": "shell", | ||
| "label": "CMake - Build NativeAudio (Debug)", | ||
| "command": "cmake", | ||
| "args": ["--build", "./NativeAudio/out", "--config", "Debug"], | ||
| "group": "build", | ||
| "problemMatcher": ["$gcc", "$msCompile"], | ||
| "dependsOn": ["CMake - generate build files"] | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix dependency label casing for the Debug build task.
The "dependsOn" field is set to "CMake - generate build files" while the actual task label is "CMake - Generate build files". Since VSCode task dependencies are case sensitive, please update it to match exactly.
- "dependsOn": ["CMake - generate build files"]
+ "dependsOn": ["CMake - Generate build files"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "type": "shell", | |
| "label": "CMake - Build NativeAudio (Debug)", | |
| "command": "cmake", | |
| "args": ["--build", "./NativeAudio/out", "--config", "Debug"], | |
| "group": "build", | |
| "problemMatcher": ["$gcc", "$msCompile"], | |
| "dependsOn": ["CMake - generate build files"] | |
| }, | |
| { | |
| "type": "shell", | |
| "label": "CMake - Build NativeAudio (Debug)", | |
| "command": "cmake", | |
| "args": ["--build", "./NativeAudio/out", "--config", "Debug"], | |
| "group": "build", | |
| "problemMatcher": ["$gcc", "$msCompile"], | |
| - "dependsOn": ["CMake - generate build files"] | |
| + "dependsOn": ["CMake - Generate build files"] | |
| }, |
Adds three VSCode tasks related to building the native audio DLL:
cmake -Scommandcmake --buildcommand with--config Debugcmake --buildcommand with--config ReleaseThe last two are dependent on the first to ensure the build files are always fresh prior to building the DLL.
These can be invoked with the Task: Run Task command in VSCode:
Summary by CodeRabbit