Make macos version work (testes on m1 at least) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vaartis
commented
Feb 25, 2024
vaartis
commented
- Change name of discord's library to libdiscord_game_sdk, so it links properly
- Change its install name with install_name_tool to use @loader_path instead of @rpath, that one's on discord's side, it should really have been loader_path from the beginning (rpath means look at where the binary is started from, loader_path means look at where the library is)
- Combine the aarch and x86 library into one, again no idea why discord does not do this themselves
1. Change name of discord's library to libdiscord_game_sdk, so it links properly 2. Change it's install name with install_name_tool to use @loader_path instead of @rpath, that one's a blunder on discord's side, it should really have been loader_path from the beginning (rpath means look at where the binary is started from, loader_path means look at where the library is) 3. Combine the aarch and x86 library into one, again no idea why discord does not do this themselves
|
okay so we got it working on intel let us test it on m1 |
vaporvee
added
enhancement
3 tasks
|
this worked on apple silicon so far wow! thank you :) will merge it when we are able to test it on intel in a day and will release it |
|
I can confirm this builds and works perfectly on my M2 mac. |
|
I can also confirm this builds and works perfectly on an Intel. I wholeheartedly approve this PR. |
|
will make a release soon! :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.