fix: use CPV with e2e tests after komenci sunset (#3139)

Komenci has been shut down and the onboarding pincode screen checks for
it's uptime before navigating to the phone verification screen. This is
not necessary with CPV, this PR adds this logic.

Update test id's - rather than update the tests i updated the test id of
the component :/ didn't think it mattered to much

Run CI, test manually

Create a new account, you should see phone verification in the
onboarding flow

n/a

Y

Co-authored-by: Charlie Andrews <charlie.andrews@valoraapp.com>

e2e/src/Rewards.spec.js

@@ -24,8 +24,8 @@ describe('Given Rewards', () => {
       await waitForElementId('ConsumerIncentives/CTA')
       await element(by.id('ConsumerIncentives/CTA')).tap()
       await enterPinUiIfNecessary()
-      await waitForElementId('VerificationEducationHeader')
-      await expect(element(by.id('VerificationEducationHeader'))).toBeVisible()
+      await waitForElementId('PhoneVerificationHeader')
+      await expect(element(by.id('PhoneVerificationHeader'))).toBeVisible()
     })
 
     it(':ios: Then should navigate back to consumer incentives', async () => {

e2e/src/usecases/NewAccountOnboarding.js

@@ -35,8 +35,8 @@ export default NewAccountOnboarding = () => {
     await enterPinUi()
 
     // Skip Phone Number verification
-    await element(by.id('VerificationEducationSkipHeader')).tap()
-    await element(by.id('VerificationSkipDialog/PrimaryAction')).tap()
+    await element(by.id('PhoneVerificationSkipHeader')).tap()
+    await element(by.id('PhoneVerificationSkipDialog/PrimaryAction')).tap()
 
     // Arrived to Home screen
     await expect(element(by.id('SendOrRequestBar'))).toBeVisible()

e2e/src/usecases/NewAccountPhoneVerification.js

@@ -169,21 +169,21 @@ export default NewAccountPhoneVerification = () => {
     await expect(element(by.text('Connect your phone number'))).toBeVisible()
     let skipAttributes = await element(by.text('Skip')).getAttributes()
     jestExpect(skipAttributes.enabled).toBe(true)
-    await waitForElementId('doINeedToConfirm')
+    await waitForElementId('PhoneVerificationLearnMore')
 
     // Tap 'Do I need to connect?' button
-    await element(by.id('doINeedToConfirm')).tap()
+    await element(by.id('PhoneVerificationLearnMore')).tap()
 
     // Assert modal action is visible
-    await waitForElementId('VerificationLearnMoreDialog/PrimaryAction')
+    await waitForElementId('PhoneVerificationLearnMoreDialog/PrimaryAction')
 
     // Assert able to dismiss modal and skip
     await element(by.text('Dismiss')).tap()
     await element(by.text('Skip')).tap()
 
-    // Assert VerificationSkipDialog modal actions are visible
-    await waitForElementId('VerificationSkipDialog/PrimaryAction')
-    await waitForElementId('VerificationSkipDialog/SecondaryAction')
+    // Assert PhoneVerificationSkipDialog modal actions are visible
+    await waitForElementId('PhoneVerificationSkipDialog/PrimaryAction')
+    await waitForElementId('PhoneVerificationSkipDialog/SecondaryAction')
 
     // Assert Back button is enabled
     let goBackButtonAttributes = await element(by.text('Go Back')).getAttributes()

e2e/src/usecases/RestoreAccountOnboarding.js

@@ -74,12 +74,12 @@ export default RestoreAccountOnboarding = () => {
   })
 
   it('Verify Education', async () => {
-    await waitForElementId('VerificationEducationSkipHeader')
+    await waitForElementId('PhoneVerificationSkipHeader')
 
     // skip
-    await element(by.id('VerificationEducationSkipHeader')).tap()
+    await element(by.id('PhoneVerificationSkipHeader')).tap()
     // confirmation popup skip
-    await element(by.id('VerificationSkipDialog/PrimaryAction')).tap()
+    await element(by.id('PhoneVerificationSkipDialog/PrimaryAction')).tap()
   })
 
   it('Wallet Home', async () => {

e2e/src/utils/utils.js

@@ -186,12 +186,12 @@ export async function quickOnboarding(mnemonic = SAMPLE_BACKUP_KEY) {
     } catch {}
 
     // Verify Education
-    await waitForElementId('VerificationEducationSkipHeader')
+    await waitForElementId('PhoneVerificationSkipHeader')
     // Skip
-    await element(by.id('VerificationEducationSkipHeader')).tap()
+    await element(by.id('PhoneVerificationSkipHeader')).tap()
     // Confirmation popup skip
-    await waitForElementId('VerificationSkipDialog/PrimaryAction')
-    await element(by.id('VerificationSkipDialog/PrimaryAction')).tap()
+    await waitForElementId('PhoneVerificationSkipDialog/PrimaryAction')
+    await element(by.id('PhoneVerificationSkipDialog/PrimaryAction')).tap()
 
     // Assert on Wallet Home Screen
     await expect(element(by.id('SendOrRequestBar'))).toBeVisible()

src/firebase/remoteConfigValuesDefaults.e2e.ts

@@ -72,6 +72,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   maxSwapSlippagePercentage: 2,
   inviteMethod: InviteMethodType.Escrow,
   showGuidedOnboardingCopy: false,
-  centralPhoneVerificationEnabled: false,
+  centralPhoneVerificationEnabled: true,
   networkTimeoutSeconds: 30,
 }

src/firebase/remoteConfigValuesDefaults.ts

@@ -71,6 +71,6 @@ export const REMOTE_CONFIG_VALUES_DEFAULTS: Omit<
   maxSwapSlippagePercentage: 2,
   inviteMethod: InviteMethodType.Escrow,
   showGuidedOnboardingCopy: false,
-  centralPhoneVerificationEnabled: false,
+  centralPhoneVerificationEnabled: true,
   networkTimeoutSeconds: 30,
 }

src/pincode/PincodeSet.tsx

@@ -13,6 +13,7 @@ import { OnboardingEvents, SettingsEvents } from 'src/analytics/Events'
 import ValoraAnalytics from 'src/analytics/ValoraAnalytics'
 import {
   biometryEnabledSelector,
+  centralPhoneVerificationEnabledSelector,
   registrationStepsSelector,
   showGuidedOnboardingSelector,
   skipVerificationSelector,
@@ -46,6 +47,7 @@ interface StateProps {
   biometryEnabled: boolean
   skipVerification: boolean
   showGuidedOnboarding: boolean
+  centralPhoneVerificationEnabled: boolean
 }
 
 interface DispatchProps {
@@ -77,6 +79,7 @@ function mapStateToProps(state: RootState): StateProps {
     biometryEnabled: biometryEnabledSelector(state),
     skipVerification: skipVerificationSelector(state),
     showGuidedOnboarding: showGuidedOnboardingSelector(state),
+    centralPhoneVerificationEnabled: centralPhoneVerificationEnabledSelector(state),
   }
 }
 
@@ -163,7 +166,7 @@ export class PincodeSet extends React.Component<Props, State> {
       navigate(Screens.ImportWallet)
     } else if (
       this.props.hideVerification ||
-      !this.props.route.params?.komenciAvailable ||
+      (!this.props.route.params?.komenciAvailable && !this.props.centralPhoneVerificationEnabled) ||
       this.props.skipVerification
     ) {
       this.props.initializeAccount()

src/redux/store.test.ts

@@ -132,7 +132,7 @@ describe('store state', () => {
           "celoEducationUri": null,
           "celoEuroEnabled": true,
           "celoWithdrawalEnabledInExchange": true,
-          "centralPhoneVerificationEnabled": false,
+          "centralPhoneVerificationEnabled": true,
           "coinbasePayEnabled": false,
           "createAccountCopyTestType": "ACCOUNT",
           "fiatConnectCashInEnabled": false,