chore: update celo tokens info lookup table in mixpanel #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wire up to CICD in a follow-on. |
cajubelt
approved these changes
Dec 1, 2023
| } | ||
|
|
||
| const lookupTables: Record<string, string> = { | ||
| 'c1881b36-7300-421d-9934-73e11d3b39d8': toCsv( |
There was a problem hiding this comment.
what is this string? seems like it should be a named constant or at least explained in a code comment
|
|
||
| const lookupTables: Record<string, string> = { | ||
| 'c1881b36-7300-421d-9934-73e11d3b39d8': toCsv( | ||
| '../src/data/mainnet/celo-tokens-info.json', |
There was a problem hiding this comment.
this seems brittle. we've already moved tokens info jsons once, and might do it again, for instance to ts files to get static validation
There was a problem hiding this comment.
have you tried putting a non-existent filename here to see what happens? seems like we'd at least want a descriptive error message
There was a problem hiding this comment.
and maybe even a CI step checking that this file exists. which we could do if the path were an exported constant and we included a script that just looks for the file in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.