Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable CRV swapping #283

Merged
merged 1 commit into from
Nov 1, 2023
Merged

chore: disable CRV swapping #283

merged 1 commit into from
Nov 1, 2023

Conversation

silasbw
Copy link
Contributor

@silasbw silasbw commented Nov 1, 2023

...was impacted by the Multichain hack, so let's prevent people from swapping into CRV. (There's also very few txs total on CELO over the last 100 days).

...was impacted by the Multichain hack, so let's prevent people from swapping
into CRV. (There's also very few txs total on CELO over the last 100 days).
Copy link
Contributor

@dievazqu dievazqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think... We have to manually remove the minimumAppVersionToSwap field because the code does not remove fields for the tokensInfo.
Before adding the new field this wasn't a problem since we could use isSwappable.
We should modify the script to remove all the extra fields (except for the price field), I can take a look at this tomorrow so we can clean this

@silasbw silasbw merged commit 1768432 into main Nov 1, 2023
6 checks passed
@silasbw silasbw deleted the crv0 branch November 1, 2023 21:47
@silasbw
Copy link
Contributor Author

silasbw commented Nov 1, 2023

ah, makes sense. thanks diego.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants