Parse and serialize Step resources as WorkloadResources #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hylje
commented
Nov 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 92.09% 92.10%
=======================================
Files 65 65
Lines 2088 2114 +26
Branches 356 360 +4
=======================================
+ Hits 1923 1947 +24
- Misses 81 82 +1
- Partials 84 85 +1 ☔ View full report in Codecov by Sentry. |
hylje
force-pushed
the
leo-step-workload-resources
branch
from
c98c70d to
7c76fbf
Compare
hylje
force-pushed
the
leo-step-workload-resources
branch
from
7c76fbf to
bc5b464
Compare
teroyks
reviewed
Dec 1, 2023
teroyks
reviewed
Dec 1, 2023
teroyks
previously approved these changes
Dec 1, 2023
hylje
force-pushed
the
leo-step-workload-resources
branch
from
0c53324 to
b6c6ae1
Compare
akx
reviewed
Dec 1, 2023
teroyks
previously approved these changes
Dec 1, 2023
hylje
force-pushed
the
leo-step-workload-resources
branch
from
b6c6ae1 to
4bc08ab
Compare
|
@akx takes a look of this. |
akx
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step will now always populate its
resourcesattribute with aWorkloadResourcesobject, which will additionally always populate its full structure down to the value fields so you can query it easily. Empty resources will serialise back into nothing when outputting back into YAML.