Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#359 General improvements lighthouse testing #365

Merged
merged 3 commits into from
May 6, 2024
Merged

#359 General improvements lighthouse testing #365

merged 3 commits into from
May 6, 2024

Conversation

BeneRichi
Copy link

@BeneRichi BeneRichi commented Feb 20, 2024 •
edited
Loading

Pull request

Improves Lighthouse test. Adds role on li element in ul list.

Ticket

Browser testing

Checklist

  • I merged the current development branch (before testing)
  • Added JSDoc and styleguide demo
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did run automated tests and linters
  • Did assign ticket
  • Double checked target branch

Review/Test checklist

  • Did review code and documentation
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did check accessibility (Wave, only errors)
  • Re-assign ticket to developer

@BeneRichi BeneRichi changed the title Feature/359 general improvements lighthouse testing #359 General improvements lighthouse testing Feb 20, 2024
@BeneRichi BeneRichi changed the base branch from master to develop February 20, 2024 14:22
@mob8607 mob8607 changed the base branch from develop to master April 17, 2024 08:34
mob8607
mob8607 requested changes Apr 17, 2024
View reviewed changes
src/components/c-tabs.vue Outdated Show resolved Hide resolved
@mob8607 mob8607 assigned mob8607 and BeneRichi and unassigned mob8607 May 2, 2024
@mob8607 mob8607 merged commit 43e5088 into main May 6, 2024
@mob8607 mob8607 deleted the feature/359_General_improvements_lighthouse_testing branch May 6, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mob8607 mob8607 mob8607 approved these changes

Assignees

@BeneRichi BeneRichi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeneRichi @mob8607