This repository was archived by the owner on Jun 14, 2024. It is now read-only.
feat(peer-exchange): support peer retrieval by cluster/shard #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm-clius
suggested changes
Nov 2, 2023
| @@ -44,12 +44,13 @@ The responder SHOULD provide a set of peers that has been retrieved using ambien | |||
| This both protects the responder's anonymity as well as helps distributing load. | |||
|
|
|||
| To allow for fast responses, responders SHOULD retrieve peers unsolicited (before receiving a query) | |||
| and maintain a queue of peers for the purpose of providing them in peer exchange responses. | |||
| and maintain a queue of peers by their `cluster_id`/`shard` for the purpose of providing them in peer exchange responses. | |||
There was a problem hiding this comment.
Might need to link to the RFC here where these concepts are defined.
There was a problem hiding this comment.
There is no rfc for this. Previous approve was to maintain a LRU for peers, and remove the oldest when the capacity is reached. This cache data structure should account for cluster id and shard id for easier retrieval by shard. This is the PR where i created the maintained ds for go-waku. waku-org/go-waku#840
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
Co-authored-by: Hanno Cornelius <68783915+jm-clius@users.noreply.github.com>
|
Continue discussion at waku-org/specs#6. Some Waku rfcs are being moved to waku/specs repo as there will be a new rfc process. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.