Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAW/SDS: Reconsider message and channel id fields for Message type #137

Open
adklempner opened this issue Mar 8, 2025 · 0 comments
Open

Comments

@adklempner
Copy link
Member

Per @jm-clius (#130 (comment)) :

While we're here, should we review the field types for the rest of the Message? The choice of string for message_id and channel_id was heavily influenced by similar protocols and current Status code, but might not be the most practical from implementation perspective: I can imagine bytes perhaps being more reasonable for message_id and int32 for channel_id.

Any opinions here? cc @shash256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant