You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From my experience, christmas eve and new year's eve are not considered holidays. Some companies consider it a half-day, but that's not guaranteed. Not sure if they should remain as OPTIONAL or be considered as HALF_DAY or UNOFFICIAL instead.
If any of those changes sound good, I’d be happy to help implement them!
Thanks!
The text was updated successfully, but these errors were encountered:
I would say the difference between WORKDAY and UNOFFICIAL is that the former is officially observed by the government via an act/decree but not declared as a holiday, while UNOFFICIAL is commonly observed by the people there but didn't have official recognition status or events held for it by the state. In this case, Mother's Day would be considered WORKDAY instead since it was officially signed into a decree by Getúlio Vargas in 1932 while Valentine's Day would be UNOFFICIAL
Exactly as you suggested here.
It should remain OPTIONAL IMO if they're usually added as company holidays.
Brazilian holidays have recently been revamped by @KJhellico. Please take a look, and if you notice any areas for improvement, feel free to contribute! We’re always happy to accept PRs from contributors with hands-on experience with local holidays.
For reference, we typically base our decisions on official documents, acts, decrees, etc. (see @PPsyrius's example above). Additionally, we’ve recently introduced holiday categories to enhance organization and clarity.
Hello,
I have some questions regarding Brazilian holidays:
UNOFFICIAL
? Father's day and mother's day are also listed here;HALF_DAY
category has been created, could this change be implemented?OPTIONAL
or be considered asHALF_DAY
orUNOFFICIAL
instead.If any of those changes sound good, I’d be happy to help implement them!
Thanks!
The text was updated successfully, but these errors were encountered: