Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions regarding Brazilian holidays #2128

Open
pedrovidal opened this issue Nov 15, 2024 · 2 comments
Open

Questions regarding Brazilian holidays #2128

pedrovidal opened this issue Nov 15, 2024 · 2 comments
Assignees

Comments

@pedrovidal
Copy link

Hello,

I have some questions regarding Brazilian holidays:

  1. In Brazil, there are a few important dates that aren't currently listed, like mother's day (second sunday in may, same as USA), father's day (second sunday in august), easter (as mentioned in Easter Sunday missing on Brazil, there is an explanation?! #1703) and valentine's day (celebrated on june 12th). Those are not considered holidays but are celebrated, so would it be possible to add them as UNOFFICIAL? Father's day and mother's day are also listed here;
  2. As mentioned in Ash Wednesday holiday in Brazil should not last the whole day #292, ash wednesday is a half-day holiday. Since the HALF_DAY category has been created, could this change be implemented?
  3. From my experience, christmas eve and new year's eve are not considered holidays. Some companies consider it a half-day, but that's not guaranteed. Not sure if they should remain as OPTIONAL or be considered as HALF_DAY or UNOFFICIAL instead.

If any of those changes sound good, I’d be happy to help implement them!

Thanks!

@PPsyrius
Copy link
Collaborator

PPsyrius commented Nov 15, 2024

  1. I would say the difference between WORKDAY and UNOFFICIAL is that the former is officially observed by the government via an act/decree but not declared as a holiday, while UNOFFICIAL is commonly observed by the people there but didn't have official recognition status or events held for it by the state. In this case, Mother's Day would be considered WORKDAY instead since it was officially signed into a decree by Getúlio Vargas in 1932 while Valentine's Day would be UNOFFICIAL

  2. Exactly as you suggested here.

  3. It should remain OPTIONAL IMO if they're usually added as company holidays.

@arkid15r
Copy link
Collaborator

Hi @pedrovidal,

Brazilian holidays have recently been revamped by @KJhellico. Please take a look, and if you notice any areas for improvement, feel free to contribute! We’re always happy to accept PRs from contributors with hands-on experience with local holidays.

For reference, we typically base our decisions on official documents, acts, decrees, etc. (see @PPsyrius's example above). Additionally, we’ve recently introduced holiday categories to enhance organization and clarity.

@arkid15r arkid15r self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants