feat(FormLayout): add FormItem and labelsAside support to autoResponsive mode #8729
+589
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces an autoResponsive mode to FormLayout. In this mode, the component automatically creates and then dynamically adjusts columns based on the provided columnWidth, maxColumns, and the available space in the container.
vursen
changed the title
vursen
force-pushed
the
feat/auto-responsive-form-layout-labels-aside
branch
2 times, most recently
from
4945b14 to
1ec9d8d
Compare
wip improve dev page example minimize diff update material screenshots
vursen
force-pushed
the
feat/auto-responsive-form-layout-labels-aside
branch
from
00b3304 to
4547b11
Compare
…' into feat/auto-responsive-form-layout-labels-aside
…' into feat/auto-responsive-form-layout-labels-aside
…form-layout-labels-aside
web-padawan
reviewed
Feb 26, 2025
| @@ -1,7 +1,7 @@ | |||
| /* @web/test-runner snapshot v1 */ | |||
| export const snapshots = {}; | |||
|
|
|||
| snapshots["vaadin-form-layout auto-responsive basic host default"] = | |||
| snapshots["vaadin-form-layout auto-responsive basic host default"] = | |||
There was a problem hiding this comment.
I think these whitespace changes should not be needed. Please consider removing form-layout.test.snap.js file and running yarn update:snapshots --group form-layout again, then the file will be regenerated correctly.
This would rearrange some snapshots to match the order of the newly added tests.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<vaadin-form-item>elements with labels positioned above inputs by default when used with autoResponsive (which is opposite to its default behavior with responsiveSteps).labelsAsideproperty, which allows<vaadin-form-item>labels to be displayed next to inputs when there is enough space in the container.Fixes #8687
Type of change