-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use _onResize instead of IntersectionObserver #8620
refactor: use _onResize instead of IntersectionObserver #8620
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We probably can backport this to 24.6
and 24.5
for consistency.
Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually? |
Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually? |
This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version. |
Description
Removes
IntersectionObserver
from FormLayout in favor of ResizeMixin's_onResize
which is also triggered when the element's visibility changes as a result ofdisplay: none
or any other method that completely removes the element from the render tree.Part of #8583
Type of change