Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use _onResize instead of IntersectionObserver #8620

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Feb 3, 2025

Description

Removes IntersectionObserver from FormLayout in favor of ResizeMixin's _onResize which is also triggered when the element's visibility changes as a result of display: none or any other method that completely removes the element from the render tree.

Part of #8583

Type of change

  • Refactor

Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We probably can backport this to 24.6 and 24.5 for consistency.

@vursen vursen merged commit 9ebf93b into main Feb 3, 2025
9 checks passed
@vursen vursen deleted the refactor/replace-intersection-observer-with-on-resize branch February 3, 2025 14:32
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 9ebf93b
error: could not apply 9ebf93b... refactor: use _onResize instead of IntersectionObserver (#8620)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 9ebf93b
error: could not apply 9ebf93b... refactor: use _onResize instead of IntersectionObserver (#8620)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha10 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants