test: extract assertFormLayoutGrid test helper

vaadin · Feb 25, 2025 · 482c5e9 · 482c5e9
1 parent 72d3d93
commit 482c5e9
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 56 deletions.
diff --git a/packages/form-layout/test/form-layout-auto-responsive.test.js b/packages/form-layout/test/form-layout-auto-responsive.test.js
@@ -3,30 +3,7 @@ import { fixtureSync, nextFrame, nextResize } from '@vaadin/testing-helpers';
 import '../src/vaadin-form-layout.js';
 import '../src/vaadin-form-item.js';
 import '../src/vaadin-form-row.js';
-
-function assertFormLayoutGrid(layout, { columns, rows }) {
-  const children = [...layout.children];
-  expect(new Set(children.map((child) => child.offsetLeft)).size).to.equal(columns, `expected ${columns} columns`);
-  expect(new Set(children.map((child) => child.offsetTop)).size).to.equal(rows, `expected ${rows} rows`);
-}
-
-function assertFormLayoutLabelPosition(layout, { position }) {
-  const columnWidth = parseFloat(layout.columnWidth);
-  const labelWidth = parseFloat(getComputedStyle(layout).getPropertyValue('--vaadin-form-layout-label-width'));
-  const labelSpacing = parseFloat(getComputedStyle(layout).getPropertyValue('--vaadin-form-layout-label-spacing'));
-
-  [...layout.children].forEach((child) => {
-    if (child.localName !== 'vaadin-form-item') {
-      return;
-    }
-
-    if (position === 'aside') {
-      expect(child.offsetWidth).to.equal(columnWidth + labelWidth + labelSpacing, 'expected labels to be aside');
-    } else {
-      expect(child.offsetWidth).to.equal(columnWidth, 'expected labels to be above');
-    }
-  });
-}
+import { assertFormLayoutGrid, assertFormLayoutLabelPosition } from './helpers.js';
 
 describe('form-layout auto responsive', () => {
   let container, layout, fields;

diff --git a/packages/form-layout/test/helpers.js b/packages/form-layout/test/helpers.js
@@ -0,0 +1,31 @@
+import { expect } from '@vaadin/chai-plugins';
+
+/**
+ * Asserts that the given form layout has the specified number of columns and rows.
+ */
+export function assertFormLayoutGrid(layout, { columns, rows }) {
+  const children = [...layout.children];
+  expect(new Set(children.map((child) => child.offsetLeft)).size).to.equal(columns, `expected ${columns} columns`);
+  expect(new Set(children.map((child) => child.offsetTop)).size).to.equal(rows, `expected ${rows} rows`);
+}
+
+/**
+ * Asserts that the given form layout has the specified label position.
+ */
+export function assertFormLayoutLabelPosition(layout, { position }) {
+  const columnWidth = parseFloat(layout.columnWidth);
+  const labelWidth = parseFloat(getComputedStyle(layout).getPropertyValue('--vaadin-form-layout-label-width'));
+  const labelSpacing = parseFloat(getComputedStyle(layout).getPropertyValue('--vaadin-form-layout-label-spacing'));
+
+  [...layout.children].forEach((child) => {
+    if (child.localName !== 'vaadin-form-item') {
+      return;
+    }
+
+    if (position === 'aside') {
+      expect(child.offsetWidth).to.equal(columnWidth + labelWidth + labelSpacing, 'expected labels to be aside');
+    } else {
+      expect(child.offsetWidth).to.equal(columnWidth, 'expected labels to be above');
+    }
+  });
+}
diff --git a/test/integration/dialog-form-layout.test.js b/test/integration/dialog-form-layout.test.js
@@ -1,34 +1,10 @@
-import { expect } from '@vaadin/chai-plugins';
 import { setViewport } from '@vaadin/test-runner-commands';
 import { fixtureSync, nextFrame, nextRender, nextResize } from '@vaadin/testing-helpers';
 import './not-animated-styles.js';
 import '@vaadin/form-layout';
 import '@vaadin/form-layout/vaadin-form-item.js';
 import '@vaadin/dialog';
-
-function assertFormLayoutGrid(layout, { columns, rows }) {
-  const children = [...layout.children];
-  expect(new Set(children.map((child) => child.offsetLeft)).size).to.equal(columns, `expected ${columns} columns`);
-  expect(new Set(children.map((child) => child.offsetTop)).size).to.equal(rows, `expected ${rows} rows`);
-}
-
-function assertFormLayoutLabelPosition(layout, { position }) {
-  const columnWidth = parseFloat(layout.columnWidth);
-  const labelWidth = parseFloat(getComputedStyle(layout).getPropertyValue('--vaadin-form-layout-label-width'));
-  const labelSpacing = parseFloat(getComputedStyle(layout).getPropertyValue('--vaadin-form-layout-label-spacing'));
-
-  [...layout.children].forEach((child) => {
-    if (child.localName !== 'vaadin-form-item') {
-      return;
-    }
-
-    if (position === 'aside') {
-      expect(child.offsetWidth).to.equal(columnWidth + labelWidth + labelSpacing, 'expected labels to be aside');
-    } else {
-      expect(child.offsetWidth).to.equal(columnWidth, 'expected labels to be above');
-    }
-  });
-}
+import { assertFormLayoutGrid, assertFormLayoutLabelPosition } from '@vaadin/form-layout/test/helpers.js';
 
 describe('form-layout in dialog', () => {
   let dialog, layout;

diff --git a/test/integration/horizontal-layout-form-layout.test.js b/test/integration/horizontal-layout-form-layout.test.js
@@ -1,15 +1,9 @@
-import { expect } from '@vaadin/chai-plugins';
 import { setViewport } from '@vaadin/test-runner-commands';
 import { fixtureSync, nextFrame } from '@vaadin/testing-helpers';
 import './not-animated-styles.js';
 import '@vaadin/form-layout';
 import '@vaadin/horizontal-layout';
-
-function assertFormLayoutGrid(layout, { columns, rows }) {
-  const children = [...layout.children];
-  expect(new Set(children.map((child) => child.offsetLeft)).size).to.equal(columns);
-  expect(new Set(children.map((child) => child.offsetTop)).size).to.equal(rows);
-}
+import { assertFormLayoutGrid } from '@vaadin/form-layout/test/helpers.js';
 
 describe('form-layouts in horizontal-layout', () => {
   let horizontalLayout, formLayouts;