-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement colors in custom formatting for vaadin-spreadsheet #7148
base: main
Are you sure you want to change the base?
feat: Implement colors in custom formatting for vaadin-spreadsheet #7148
Conversation
|
...thus making some of the code look really, really ugly.
….com/thevaadinman/flow-components into feat-conditional-formatting-20250128
SonarCloud Code Analysis result can be ignored, it's hallucinating and complaining about existing code. |
/* | ||
* The Vaadin CI pipeline requires Vaadin's license header to be first in the file. | ||
* While this file is modified, most of it was part of Apache POI, which is licensed | ||
* under the Apache License, Version 2.0. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's exclude this class from the formatter to preserve the license header and not add our own:
Lines 547 to 550 in 695e072
<excludes> | |
<!-- Do not modify GWT sources / license headers --> | |
<exclude>**/com/google/gwt/**/*.*</exclude> | |
</excludes> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll also return the file to its original unmangled state
Looks like I'll have to shim the custom cell formatting bits. This will take a while. |
….com/thevaadinman/flow-components into feat-conditional-formatting-20250128
|
There seems to be a hard-to-resolve issue with getting the reworked CellFormatPart class to load reliably. All tests thus far have worked locally, but something seems very different on the CI cluster. |
Description
Fixes #6835. Does not introduce new public API. Enables the use of named colors and indexed colors
compatible with Excel: black, white, red, green, blue, yellow, magenta, cyan, as well as Color 1-56.
Type of change
Checklist
Additional for
Feature
type of change