-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detection Library #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm conflicted about the namespaces Detector
vs Detection
they don't really server their purpose to distinguish between the two parts. I might even consider just dropping the Detection
one or just nest it under Detector
if we don't find a better separation.
protected ?string $fallbackFile; | ||
|
||
public function __construct(?string $fallbackFile = null) | ||
{ | ||
$this->fallbackFile = $fallbackFile; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected ?string $fallbackFile; | |
public function __construct(?string $fallbackFile = null) | |
{ | |
$this->fallbackFile = $fallbackFile; | |
} | |
public function __construct(protected ?string $fallbackFile = null) | |
{ | |
} |
$matches = array_intersect($this->inputs, SSR::FRAMEWORK_FILES[$this->framework]); | ||
|
||
if (count($matches) > 0) { | ||
return new SSR(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return new SSR(null); | |
return new SSR(); |
if (count($htmlFiles) === 1) { | ||
return new SSG($htmlFiles[0]); | ||
} else { | ||
return new SSG(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return new SSG(null); | |
return new SSG(); |
Detection Library PR to detect the following: