Add effect of radio wave propagation time to geometric distance calculation #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukudakazuya
added
priority::medium
fukudakazuya
requested review from
200km,
ogoogo,
Hiro-0110,
seki-hiro,
suzuki-toshihir0,
t-hosonuma and
conjikidow
and removed request for
a team
200km
reviewed
Feb 1, 2025
|
コメントありがとうございました．修正しました． |
200km
reviewed
Feb 4, 2025
| @@ -32,6 +32,11 @@ EpochTime::EpochTime(const DateTime date_time) { | |||
| fraction_s_ = date_time.GetSecond() - (double)second; | |||
| } | |||
|
|
|||
| EpochTime::EpochTime(const double time_with_fraction_s) { | |||
| time_s_ = static_cast<uint64_t>(std::floor(time_with_fraction_s)); | |||
There was a problem hiding this comment.
[MUST] 負の値の場合、0を入れたEpochTimeを返すようにお願いします。
|
修正しました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#600
Description
以下を幾何学的距離の計算に追加した．
また，gnss_receiver.iniにpseudorange_loggingを追加し，擬似距離計算のログ出力をするかどうか設定できるようにした（前回実装し忘れていた）
Test results
受信機に信号が届いた時刻における受信機とGNSS衛星との距離と，電波伝播時間とサニャック効果を考慮した擬似距離（ノイズを0としているので幾何学的距離に等しい）との差をプロットした．
Impact
Describe the scope of influence of the changes, e.g.,
The behavior of feature ** changes.Supplementary information
Provide any supplementary information.