Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#82 find id password #83

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Feature/#82 find id password #83

merged 5 commits into from
Jan 8, 2024

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Jan 8, 2024

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ์•„์ด๋”” ์ฐพ๊ธฐ, ๋น„๋ฒˆ ์ฐพ๊ธฐ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค~!

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์•„์ด๋”” ์ฐพ๊ธฐ ๋น„๋ฒˆ ์ฐพ๊ธฐ
แ„‹แ…กแ„‹แ…ตแ„ƒแ…ต แ„Žแ…กแ†ฝแ„€แ…ต แ„‡แ…ตแ„‡แ…ฅแ†ซแ„Žแ…กแ†ฝแ„€แ…ต

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu added the feature label Jan 8, 2024
@jinukeu jinukeu requested a review from BEEEAM-J January 8, 2024 08:00
@jinukeu jinukeu self-assigned this Jan 8, 2024
BEEEAM-J
BEEEAM-J approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~~!!
๊ถ๊ธˆํ•œ ์  ์žˆ์–ด์„œ ์งˆ๋ฌธ ๋‚จ๊น๋‹ˆ๋‹ค!

BEEEAM-J
BEEEAM-J reviewed Jan 8, 2024
View reviewed changes
feature/login/src/main/java/com/suwiki/feature/login/findpassword/FindPasswordScreen.kt
SuwikiContainedLargeButton(
modifier = Modifier.imePadding(),
text = stringResource(R.string.word_find_password),
onClick = onClickFindPasswordButton,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด ๋™์ž‘์œผ๋กœ ๋น„๋ฐ€๋ฒˆํ˜ธ ์ฐพ๋Š” api ํ˜ธ์ถœํ•˜๋Š” ๊ฑฐ ๊นŒ์ง€๋Š” ์ดํ•ด๊ฐ€ ๋๋Š”๋ฐ toast ๋ฉ”์„ธ์ง€๋ฅผ ๋„์šฐ๋Š” ๋™์ž‘์€ ์–ด๋””์— ์ •์˜ ๋˜์–ด ์žˆ๋Š” ๊ฑด๊ฐ€์š”??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

findPasswordUseCase(loginId = state.id, email = state.email)
      .onSuccess {
        reduce { state.copy(showFindPasswordSuccessDialog = true) }
      }
      .onFailure {
        postSideEffect(FindPasswordSideEffect.HandleException(it))
      }

์—ฌ๊ธฐ ๋ณด์‹œ๋ฉด ์‹คํŒจํ•œ ๊ฒฝ์šฐ์— HandleException SideEffect๋ฅผ ๋ฐœ์ƒ์‹œํ‚ต๋‹ˆ๋‹ค!
HandleException์€ MainScreen๊นŒ์ง€ ์ „๋‹ฌ๋˜๊ตฌ์šฉ MainScreen์—์„œ ํ† ์ŠคํŠธ๋ฅผ ๋„์›๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ํ•˜! ๊ทธ๋ž˜์„œ ์Šคํฌ๋ฆฐ์—์„œ ๋”ฐ๋กœ ํ† ์ŠคํŠธ๋ฅผ ๋„ฃ์ง€ ์•Š์•˜๋˜๊ฑฐ๊ตฐ์š”
์ฐธ๊ณ ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค :)

@jinukeu jinukeu merged commit e257aef into develop Jan 8, 2024
1 check passed
@jinukeu jinukeu deleted the feature/#82-find-id-password branch January 9, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BEEEAM-J BEEEAM-J BEEEAM-J approved these changes

Assignees

@jinukeu jinukeu

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] ์•„์ด๋””, ๋น„๋ฐ€๋ฒˆํ˜ธ ์ฐพ๊ธฐ
2 participants
@jinukeu @BEEEAM-J