Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#113 write evaluation #114

Merged
merged 9 commits into from
Jan 24, 2024
Merged

Feature/#113 write evaluation #114

merged 9 commits into from
Jan 24, 2024

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Jan 23, 2024

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ๊ฐ•์˜ํ‰๊ฐ€ ์ž‘์„ฑ
  • ์‹œํ—˜์ •๋ณด ์ž‘์„ฑ
  • ์‹ ๊ณ  ๊ธฐ๋Šฅ

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu
feat/#113: ๊ฐ•์˜ํ‰๊ฐ€ ์ƒ์„ธ ํ™”๋ฉด ์ด๋™ ์‹œ, ๋กœ๊ทธ์ธ์ด ์•ˆ๋œ ๊ฒฝ์šฐ ๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์ด๋™ํ•˜๊ฒŒ๋” ์ˆ˜์ •
a4eb945
@jinukeu
feat/#113: ๊ฐ•์˜ํ‰๊ฐ€ ์ƒ์„ธ ํ™”๋ฉด -> ์ž‘์„ฑ ํ™”๋ฉด ์ด๋™ ๊ตฌํ˜„
ee6ea11
@jinukeu
rename/#113: EvaluationEditor rename
4dc9652
@jinukeu
feat/#113: ๊ฐ•์˜/์‹œํ—˜ ์ •๋ณด ํ‰๊ฐ€ ์‹œ, ๋ชจ๋“  ๊ฐ’์ด ์ž…๋ ฅ๋˜์ง€ ์•Š๋Š” ๊ฒฝ์šฐ ์ฒ˜๋ฆฌ
0edd60c
@jinukeu
feat/#113: ๊ฐ•์˜ํ‰๊ฐ€ ์ž‘์„ฑ ๊ธฐ๋Šฅ ๊ตฌํ˜„
735ba97
@jinukeu
feat/#113: ์‹œํ—˜์ •๋ณด ์ž‘์„ฑ ๊ธฐ๋Šฅ ๊ตฌํ˜„
6de4098
@jinukeu
feat/#113: ๊ฐ•์˜ํ‰๊ฐ€, ์‹œํ—˜ ์ •๋ณด ์‹ ๊ณ  ๊ธฐ๋Šฅ ๊ตฌํ˜„
fe1d6a2
@jinukeu
feat/#113: ๊ฐ•์˜ํ‰๊ฐ€, ์‹œํ—˜ ์ •๋ณด ์‹ ๊ณ  ๊ธฐ๋Šฅ ๊ตฌํ˜„
885c9d1
@jinukeu
chore/#113: ktlint, detekt
88787df
@jinukeu jinukeu requested a review from BEEEAM-J January 23, 2024 16:49
@jinukeu jinukeu self-assigned this Jan 23, 2024
BEEEAM-J
BEEEAM-J approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ „ ๊ฐ•์˜ํ‰๊ฐ€, ์‹œํ—˜์ •๋ณด ์ž‘์„ฑ ํ™”๋ฉด์— ๋งž๊ฒŒ ๋”ฐ๋กœ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜๋Š” ์ƒ๊ฐํ–ˆ๋Š”๋ฐ ์ˆ˜์ • ํ™”๋ฉด์œผ๋กœ ์ž‘์„ฑ๊นŒ์ง€ ๊ตฌํ˜„ํ•˜์…จ๋„ค์šฉ
๊ณ ์ƒํ•˜์…จ์–ด์œ  ๐Ÿ‘๐Ÿ‘

@jinukeu jinukeu merged commit 06a2041 into develop Jan 24, 2024
1 check passed
@jinukeu jinukeu deleted the feature/#113-write-evaluation branch January 24, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BEEEAM-J BEEEAM-J BEEEAM-J approved these changes

Assignees

@jinukeu jinukeu

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] ๊ฐ•์˜/์‹œํ—˜ ํ‰๊ฐ€ ์ž‘์„ฑ ๊ธฐ๋Šฅ ๊ตฌํ˜„
2 participants
@jinukeu @BEEEAM-J