Skip to content

Commit

Permalink
Explicitly set --enable-new-dtags linker flag.
Browse files Browse the repository at this point in the history
Evaluation code running on NIST systems is compiled with mpicxx, which
sets -Wl,--enable-new-dtags in LDFLAGS. If a participant is looking in
RPATH for associated libraries, they would find them in validation but
not on NIST systems. Conversely, if they looked in RUNPATH, they would
find them on NIST systems but not during validation. This change
should create consistency between the two.
  • Loading branch information
gfiumara committed Mar 23, 2021
1 parent 9cd4a4a commit 069b9dc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion elft_1_x/validation/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
202103161717
202103231629
4 changes: 4 additions & 0 deletions elft_1_x/validation/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,9 @@ set_target_properties(elft_validation PROPERTIES
set_target_properties(elft_validation PROPERTIES
BUILD_WITH_INSTALL_RPATH TRUE)

# Use RUNPATH over RPATH
set_target_properties(elft_validation PROPERTIES
LINK_FLAGS -Wl,--enable-new-dtags)

install(TARGETS elft_validation
RUNTIME DESTINATION ${PROJECT_SOURCE_DIR}/../${CMAKE_INSTALL_BINDIR})

0 comments on commit 069b9dc

Please sign in to comment.