Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete check-ins. #401

Open
1 of 9 tasks
AmTryingMyBest opened this issue Jun 7, 2019 · 2 comments
Open
1 of 9 tasks

Unable to delete check-ins. #401

AmTryingMyBest opened this issue Jun 7, 2019 · 2 comments

Comments

@AmTryingMyBest
Copy link

AmTryingMyBest commented Jun 7, 2019

Expected Behaviour

When user tries to delete more than one check-in by clicking the Delete All button on a check-in, site is stuck on delete spinner.

Actual Behaviour

User should be able to delete all check-ins when they click on Delete All button.

Steps to Reproduce

  • Navigate to Check-Ins,
  • Under the Sent tab, click on Delete All button on a check-in that is repeated.
  • delete spinner shows up and persists, forever.

Screenshot

Screenshot from 2019-06-07 12-30-25.png

Logs

TypeError: Cannot read property 'id' of null
    at main.js:1
    at t.invoke (polyfills.js:3)
    at Object.onInvoke (vendor.js:1)
    at t.invoke (polyfills.js:3)
    at r.run (polyfills.js:3)
    at polyfills.js:3
    at t.invokeTask (polyfills.js:3)
    at Object.onInvokeTask (vendor.js:1)
    at t.invokeTask (polyfills.js:3)
    at r.runTask (polyfills.js:3)
    at o (polyfills.js:3)
    at e.invokeTask [as invoke] (polyfills.js:3)
    at p (polyfills.js:2)
    at HTMLButtonElement.v (polyfills.js:2)
    at c (polyfills.js:3)
    at polyfills.js:3
    at t.invokeTask (polyfills.js:3)
    at Object.onInvokeTask (vendor.js:1)
    at t.invokeTask (polyfills.js:3)
    at r.runTask (polyfills.js:3)
    at o (polyfills.js:3)
    at e.invokeTask [as invoke] (polyfills.js:3)
    at p (polyfills.js:2)
    at HTMLButtonElement.v (polyfills.js:2)
vendor.js:1 Error: Uncaught (in promise): TypeError: Cannot read property 'id' of null
TypeError: Cannot read property 'id' of null
    at main.js:1
    at t.invoke (polyfills.js:3)
    at Object.onInvoke (vendor.js:1)
    at t.invoke (polyfills.js:3)
    at r.run (polyfills.js:3)
    at polyfills.js:3
    at t.invokeTask (polyfills.js:3)
    at Object.onInvokeTask (vendor.js:1)
    at t.invokeTask (polyfills.js:3)
    at r.runTask (polyfills.js:3)
    at o (polyfills.js:3)
    at e.invokeTask [as invoke] (polyfills.js:3)
    at p (polyfills.js:2)
    at HTMLButtonElement.v (polyfills.js:2)
    at c (polyfills.js:3)
    at polyfills.js:3
    at t.invokeTask (polyfills.js:3)
    at Object.onInvokeTask (vendor.js:1)
    at t.invokeTask (polyfills.js:3)
    at r.runTask (polyfills.js:3)
    at o (polyfills.js:3)
    at e.invokeTask [as invoke] (polyfills.js:3)
    at p (polyfills.js:2)
    at HTMLButtonElement.v (polyfills.js:2)

Environment

  • www.tenfour.org
  • app.tenfour.org
  • staging.tenfour.org
  • dev.tenfour.org
  • localhost:8100
  • iOS App (live)
  • iOS App (testflight)
  • Android App (live)
  • Android App (beta)
@AmTryingMyBest
Copy link
Author

@dalezak this still happens.

Now when I delete a check-in, I get a confirmation that it has been deleted, and then the list goes blank. When I hit refresh page, however, all check-ins re-appear, including the one that I'd just deleted.
When I click on delete, the issue as described above occurs.

@dalezak
Copy link
Collaborator

dalezak commented Jun 11, 2019

Ok @Obadha2, I think I have this fixed, sent to @mackers for review.

Note, the Delete All button should only show up in the Scheduled tab now, since we only support deleting future unsent checkins.

@dalezak dalezak removed their assignment Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants