fix: enforce only one instance of an in-pod cronjob running at once #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to run this through the Lagoon test suite to confirm functionality. Any tips? |
We do have a cronjob features test in the test suite, you could extend that to include a cronjob that would experience the issue that flock would solve. Not sure if this is the best way to do this though? |
|
What I mean is: how do I run this through the Lagoon test suite? |
smlx
added a commit
to uselagoon/lagoon
that referenced
this pull request
Mar 8, 2023
shreddedbacon
force-pushed
the
flock-in-pod-cronjob
branch
from
88c4616 to
f88fcc2
Compare
|
I've updated this to use the service templates instead of bash. Will need to do some more testing, but seems to work well in the limited playing around I did. |
smlx
commented
Jan 21, 2025
shreddedbacon
force-pushed
the
flock-in-pod-cronjob
branch
from
f88fcc2 to
ab12c48
Compare
This change enforces that in-pod cronjobs have only one instance of the job running at any one time. Specifically, this change fixes the issue where minutely cronjobs which take longer than a minute to run result in dozens of instances of the job running at the same time. In some cases this can cause Lagoon users to DoS themselves or use excessive CPU or memory resources.
shreddedbacon
force-pushed
the
flock-in-pod-cronjob
branch
from
ab12c48 to
a102000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enforces that in-pod cronjobs have only one instance of the job running at any one time.
Specifically, this change fixes the issue where minutely cronjobs which take longer than a minute to run result in dozens of instances of the job running at the same time. In some cases this can cause Lagoon users to DoS themselves or use excessive CPU or memory resources.
Closes: uselagoon/lagoon-images#172