Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ODE reference version in pom.xml to 2.0.0-SNAPSHOT #73

Conversation

dmccoystephenson
Copy link
Contributor

Problem

The version of the ODE for the upcoming release has been updated in usdot-jpo-ode/jpo-ode#537.

Solution

The pom.xml has been updated to correctly reference the upcoming release version.

@iyourshaw
Copy link
Collaborator

iyourshaw commented Feb 23, 2024

For this to work you will need to recursively update all the submodule references in addition to the POM reference in the following projects:
jpo-geojsonconverter
jpo-conflictmonitor

Also will need to update
jpo-conflictvisualizer

@dmccoystephenson
Copy link
Contributor Author

dmccoystephenson commented Feb 23, 2024

For this to work you will need to recursively update all the submodule references in addition to the POM reference in the following projects:
jpo-geojsonconverter
jpo-conflictmonitor

Also will need to update
jpo-conflictvisualizer

I believe these submodules references should be updated after the latest changes have made it into the master branch & prior to the release, so this is outside the scope of this PR.

@iyourshaw
Copy link
Collaborator

iyourshaw commented Feb 23, 2024

This PR will cause the develop branch to break if the submodule references are not valid. The develop branch needs to be functional to do development work.

@dmccoystephenson
Copy link
Contributor Author

dmccoystephenson commented Feb 23, 2024

This PR will cause the develop branch to break if the submodule references are not valid. The develop branch needs to be functional to do development work.

Understood. I will update the submodule reference for the geojson converter in this project once usdot-jpo-ode/jpo-ode#537 and usdot-jpo-ode/jpo-geojsonconverter#52 are merged. Marking this PR as a draft for now until that is the case.

@iyourshaw
Copy link
Collaborator

This PR will cause the develop branch to break if the submodule references are not valid. The develop branch needs to be functional to do development work.

Understood. I will update the submodule reference for the geojson converter in this project once usdot-jpo-ode/jpo-ode#537 and usdot-jpo-ode/jpo-geojsonconverter#52 are merged. Marking this PR as a draft for now until that is the case.

Sounds good! 👍 😄

@dmccoystephenson dmccoystephenson changed the base branch from develop to candidate_r1 February 26, 2024 17:28
@dmccoystephenson
Copy link
Contributor Author

dmccoystephenson commented Feb 26, 2024

Since we are no longer targeting the develop branch with this PR, I don't think there is a need to update the git submodule commit references here at this time.

EDIT: This would have been correct if the git submodule commit reference got updated prior to the candidate_r1 branch being merged into master. The fact that this is not guaranteed means that we should have in fact updated the git submodule commit reference here for redundancy.

@dmccoystephenson dmccoystephenson marked this pull request as ready for review February 26, 2024 18:14
@dan-du-car dan-du-car merged commit 3b19d22 into usdot-jpo-ode:candidate_r1 Feb 26, 2024
0 of 3 checks passed
@dmccoystephenson dmccoystephenson deleted the pom/update-ode-reference-version branch February 27, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants