Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷️ Convert interfaces to type aliases #799

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

usagizmo
Copy link
Owner

@usagizmo usagizmo commented Sep 13, 2024

  • πŸ”§ Convert Card interface to type alias in Comment.svelte
  • πŸ”§ Convert Comment interface to type alias in commentStore.svelte.ts
  • πŸ”§ Convert User interface to type alias in userStore.svelte.ts

- πŸ”§ Update Card type in Comment.svelte
- πŸ”§ Refactor Comment type in commentStore.svelte.ts
- πŸ”§ Change User interface to type alias in userStore.svelte.ts
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
webapp-template-mockup βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 13, 2024 6:14pm
webapp-template-web βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 13, 2024 6:14pm

@usagizmo usagizmo enabled auto-merge (squash) September 13, 2024 18:14
@usagizmo usagizmo merged commit bb86555 into main Sep 13, 2024
4 checks passed
@usagizmo usagizmo deleted the chore/use-type branch September 13, 2024 18:18
@usagizmo
Copy link
Owner Author

I heard that type is not always a good choice, so I reverted.
https://google.github.io/styleguide/tsguide.html#interfaces-vs-type-aliases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant