Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended image support #52

Closed
tomasholderness opened this issue Aug 25, 2017 · 3 comments
Closed

Extended image support #52

tomasholderness opened this issue Aug 25, 2017 · 3 comments

Comments

@tomasholderness
Copy link
Contributor

tomasholderness commented Aug 25, 2017

1 request for large images available in client
Three folders:

  • originals
  • resized
  • resized_large

2 should we support GIFs?
cat

@matthewberryman
Copy link
Contributor

For other image sizes:

  1. The schema needs to be updated to store perhaps just the base image filename rather than the full url, so then in petabencana.id we can reconstruct the full url dynamically on the fly depending on desktop / mobile (if I understand the intent here correctly). If you care about past events you would also need to modify the database.
  2. Petabencana.id needs to be updated to select smaller / larger depending on desktop / mobile.
  3. Ditto extended image support cognicity-recognition#5 until Should we store recognition outputs in cognicity-schema cognicity-recognition#4 is finished.
  4. image-lambda processor configuration needs to be updated along with [https://github.com/urbanriskmap/image-lambda/blob/master/serverless.yml](IAM policy)

For gif upload support:

  1. We need to make sure that cards accept and upload gif files.
    Note that https://github.com/urbanriskmap/image-lambda supports non-animated gifs as inputs. I don't think we need to support animated gifs. Maybe down the track we should support proper video files?

@tomasholderness
Copy link
Contributor Author

tomasholderness commented Oct 13, 2017

@tomasholderness
Copy link
Contributor Author

Closing this as back-end functionality complete. Outstanding UI tasks tracked in urbanriskmap/riskmap#232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants