Support 4G result data #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
requested changes
Jan 6, 2025
| common methods/datasets that can be used for easy comparison.""" | ||
|
|
||
| @property | ||
| def end_use_summary_dict(self) -> dict: |
There was a problem hiding this comment.
This is returning a list, no?
There was a problem hiding this comment.
Related to that, getting mypy to run during pre-commit would be awesome. Why is it commented?
There was a problem hiding this comment.
probably because it failed tooooo much?
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
vtnate
reviewed
Jan 16, 2025
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
nllong
commented
Jan 26, 2025
vtnate
approved these changes
Jan 27, 2025
| self.assertEqual(data.number_of_buildings(), 1) | ||
|
|
||
| def test_resample_and_convert_to_df(self): | ||
| """Simple test to make sure we can load the geojson file""" |
There was a problem hiding this comment.
We should probably have different docstrings for the different tests. Something to do in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
results_baseabstract class to store data that need to be in both URBANopt results and Modelica results