Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ruff config filename #3

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Fix typo in ruff config filename #3

merged 4 commits into from
Sep 3, 2024

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Sep 3, 2024

No description provided.

@vtnate vtnate self-assigned this Sep 3, 2024
@vtnate vtnate requested a review from nllong September 3, 2024 15:05
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did I really have this as rull.toml? 😶

self.measure_args.add_argument(
"value", "Value to set the argument to", units="float"
)
self.measure_args.add_argument("type", "Name of the type being modified", units="string")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so much better! Thanks!

@@ -398,17 +324,17 @@ def resample_actual_data(self) -> None:
"converted_units",
]
new_data = self.actual_data_monthly.groupby(groupby_cols).sum()
new_data.reset_index(inplace=True)
new_data.set_index(["start_time"], inplace=True)
new_data = new_data.reset_index()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inplace is no longer needed? cool.... I learned something.

for resolution in ["min_15_with_buildings", "min_60_with_buildings"]:
df = getattr(self.modelica[analysis_name], resolution)
temp_df = getattr(self.modelica[analysis_name], resolution)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, yes yes, I know.

@vtnate
Copy link
Contributor Author

vtnate commented Sep 3, 2024

@nllong It's all ruff! Thank goodness for linting. I just do what it says.

@vtnate vtnate merged commit 1611330 into develop Sep 3, 2024
3 checks passed
@vtnate vtnate deleted the ruff-config-name branch September 3, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants