From fdaa229cb1f37244749c5139567d1e6e9a3cbe7a Mon Sep 17 00:00:00 2001 From: Samuel Gratzl Date: Sun, 29 Sep 2024 12:46:24 -0400 Subject: [PATCH] fix: linter --- package.json | 2 ++ src/__tests__/createChart.ts | 2 +- src/elements/ArcSlice.ts | 2 +- yarn.lock | 9 +++++++++ 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 2f17581..a7f2f5c 100644 --- a/package.json +++ b/package.json @@ -59,12 +59,14 @@ "@rollup/plugin-node-resolve": "^15.3.0", "@rollup/plugin-replace": "^6.0.1", "@rollup/plugin-typescript": "^12.1.0", + "@types/d3-selection": "^3.0.10", "@types/jest-image-snapshot": "^6.4.0", "@types/node": "^22.7.4", "@yarnpkg/sdks": "^3.2.0", "canvas": "^2.11.2", "canvas-5-polyfill": "^0.1.5", "chart.js": "^4.4.4", + "d3-selection": "^3.0.0", "eslint": "^9.11.1", "eslint-plugin-prettier": "^5.2.1", "jest-image-snapshot": "^6.4.0", diff --git a/src/__tests__/createChart.ts b/src/__tests__/createChart.ts index 8f581a0..249653f 100644 --- a/src/__tests__/createChart.ts +++ b/src/__tests__/createChart.ts @@ -34,7 +34,7 @@ export default function createChart< TYPE extends ChartType, DATA extends unknown[] = DefaultDataPoint, LABEL = string, - >(config: ChartConfiguration, width = 800, height = 600): ChartHelper { +>(config: ChartConfiguration, width = 800, height = 600): ChartHelper { const canvas = document.createElement('canvas'); canvas.width = width; canvas.height = height; diff --git a/src/elements/ArcSlice.ts b/src/elements/ArcSlice.ts index 4b779e8..dc6a9a5 100644 --- a/src/elements/ArcSlice.ts +++ b/src/elements/ArcSlice.ts @@ -124,7 +124,7 @@ export class ArcSlice extends Element implemen /** * @hidden */ - // eslint-disable-next-line class-methods-use-this + hasValue(): boolean { return true; } diff --git a/yarn.lock b/yarn.lock index bfee25d..0c94822 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1071,6 +1071,13 @@ __metadata: languageName: node linkType: hard +"@types/d3-selection@npm:^3.0.10": + version: 3.0.10 + resolution: "@types/d3-selection@npm:3.0.10" + checksum: 10c0/de1f99ab186a08999bf394a645fd76911add1b02316270d4c07616c8383903a2b068d7e02b73b6a99a1f26bb49a2e99ef4b55a5d2ddfa165f6f3c53144897920 + languageName: node + linkType: hard + "@types/emscripten@npm:^1.39.6": version: 1.39.13 resolution: "@types/emscripten@npm:1.39.13" @@ -2353,6 +2360,7 @@ __metadata: "@rollup/plugin-node-resolve": "npm:^15.3.0" "@rollup/plugin-replace": "npm:^6.0.1" "@rollup/plugin-typescript": "npm:^12.1.0" + "@types/d3-selection": "npm:^3.0.10" "@types/jest-image-snapshot": "npm:^6.4.0" "@types/node": "npm:^22.7.4" "@upsetjs/venn.js": "npm:^1.4.2" @@ -2360,6 +2368,7 @@ __metadata: canvas: "npm:^2.11.2" canvas-5-polyfill: "npm:^0.1.5" chart.js: "npm:^4.4.4" + d3-selection: "npm:^3.0.0" eslint: "npm:^9.11.1" eslint-plugin-prettier: "npm:^5.2.1" jest-image-snapshot: "npm:^6.4.0"